java - Fibonacci Recursion? -

-

i have started learn recursion. program i'm asked make should take term input, , output corresponding fibonacci number. have far, it's showing error. what's wrong?

thanks in advance!

private void btnfindnumberactionperformed(java.awt.event.actionevent evt) {                                                   int term = integer.parseint(txtinputterm.gettext());     int number = fibonacci(term);     txtoutput.settext("fibonacci number " + term + " " + number); }                                               public int fibonacci (int term) {     if (term == 1) {         return term;     } else {        int number = fibonacci(term-1) + fibonacci(term-2);        return number;     } }

imagine fibonacci term being 2. happen?

  • term == 1 ? wrong, continue else...
  • so try calling fibonacci(term-1) ( = fibonacci(1) ) + fibonacci(term-2) ( = fibonacci(0) )

ok, fibonacci(term-1) ( = fibonacci(1) )...

  • term == 1 ? true, returning 1

ok, fibonacci(term-2) ( = fibonacci(0) )

  • term == 1 ? false, because it's zero. , goes downhill there, since numbers negative , never step term == 1.

so, perhaps might wish think again if criteria should equal 1 or perhaps different.

as more technical explanation, since mentioned in comments: when calling method, data stored on called "stack". if call, example, method a, calls b, data (at least) 2 methods stored on stack. if b again calls method, again, again... stack overflow, dreaded stackoverflowexception. happens when getting return conditions wrong on recursive method.

and last comment: don't recursive methods unless need to. imagine need learn now, in future, don't forget recursion elegant concept - in math, not in coding, tends lead problems (like 1 - , fact calculating fibonacci recursively worst way so).


Comments

Post a Comment

Popular posts from this blog

php - Admin SDK -- get information about the group -

-
please, help. https://www.googleapis.com/admin/directory/v1/groups/106274944935548788283 sending request obtain information group id 1062 ... here link method in google https://developers.google.com/admin-sdk/directory/v1/guides/manage-groups#get_group in response error - 401 unauthorized. oauth authenticate via user has received rights necessary request, included in console admin sdk. authorization successful, there token. not can not understand. if not hard - response. requested information: file_get_contents("https://www.googleapis.com/admin/directory/v1/groups/1062749‌​44935548788283?key=aizasybruhiomdf9nlx9lx3imxwesqmcrnhh4l4"); id group - "106274944935548788283" key applications in case - "aizasybruhiomdf9nlx9lx3imxwesqmcrnhh4l4" error: failed open stream: http request failed! http/1.0 401 unauthorized
Read more

dns - How To Use Custom Nameserver On Free Cloudflare? -

-
i have problem. i own small hosting company. trying add cloudflare site free cdn. problem when sign have change nameservers nameservers. have nameserver dns set through godaddy, how add them cloudflare? main site uses company's nameservers whenever add them site goes offline. when go cloudflare's dns records click on dropdown, click ns, , there's 2 boxes 'name' , 'nameserver'. mean input 'ns1' 'name' , 'ns1.domain.com' 'nameserver'? input server's ip addresses? is there way of accomplishing free version of cloudflare? that impossible. option have custom name servers available on business , enterprise. see https://www.cloudflare.com/plans . also, might mistaken. must change name servers in domain register settings, not on cloudflare.
Read more

Python Error - TypeError: input expected at most 1 arguments, got 3 -

-
can explain why can not use your_name in goal variable? my_name = "bryson" my_age = 29 your_name = input ("what name? ") your_age = input ("what age? ") print ("my name is", my_name,", , am", my_age, "years old.") print ("your name is", your_name,", , are", your_age,".") print("thank buying book,", your_name,"!") goal = input ("what favorite part of book,", your_name, "?") print("awesome!") the error is: goal = input ("what favorite part of book,", your_name, "?") typeerror: input expected @ 1 arguments, got 3 you got error because in fact gave 3 arguments input function when expecting 1 (namely, string prompt). in input ("what favorite part of book,", your_name, "?") ---------------------------------------- , ---------, --- the underlined parts comma-separated arguments: st...
Read more